]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
video: nexell: unsigned parameter cannot be negative
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Wed, 1 Oct 2025 10:05:10 +0000 (11:05 +0100)
committerMinkyu Kang <mk7.kang@samsung.com>
Tue, 3 Feb 2026 01:42:03 +0000 (10:42 +0900)
The parameter 'alpha' is declared as an unsigned type so cannot be
negative. The code to test it as being less than zero will always fail
and so is redundant and should be removed.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Stefan Bosch <stefan_b@posteo.net>
Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
drivers/video/nexell/soc/s5pxx18_soc_mlc.c

index c8cf833f308836aa9205f4ed2148e41075b83c29..2c8348bf633929272d084b407dd4bc247eff21b4 100644 (file)
@@ -1641,8 +1641,6 @@ void nx_mlc_set_layer_alpha256(u32 module_index, u32 layer, u32 alpha)
        u32 register_data;
        register struct nx_mlc_register_set *pregister;
 
-       if (alpha < 0)
-               alpha = 0;
        if (alpha > 255)
                alpha = 255;