]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev: fix review mixup
authorLuca Boccassi <luca.boccassi@gmail.com>
Fri, 13 Mar 2026 11:10:47 +0000 (11:10 +0000)
committerLuca Boccassi <luca.boccassi@gmail.com>
Fri, 13 Mar 2026 14:20:05 +0000 (14:20 +0000)
The previous version in the PR changed variable and sanitized it
in place. The second version switched to skip if CCs are in the
string instead, but didn't move back to the original variable.
Because it's an existing variable, no CI caught it.

Follow-up for 16325b35fa6ecb25f66534a562583ce3b96d52f3

src/udev/scsi_id/scsi_id.c

index b57f31b5935f49ef331fb9a32a9bfc407df7fa7a..e3438897199f9c719d3a43bff28b986076553e26 100644 (file)
@@ -443,7 +443,7 @@ static int scsi_id(char *maj_min_dev) {
                 if (dev_scsi.tgpt_group[0] != '\0')
                         printf("ID_TARGET_PORT=%s\n", dev_scsi.tgpt_group);
                 if (dev_scsi.unit_serial_number[0] != '\0' && utf8_is_valid(dev_scsi.unit_serial_number) && !string_has_cc(dev_scsi.unit_serial_number, /* ok= */ NULL))
-                        printf("ID_SCSI_SERIAL=%s\n", serial_str);
+                        printf("ID_SCSI_SERIAL=%s\n", dev_scsi.unit_serial_number);
                 goto out;
         }