]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: amd-mdb: Correct IRQ number in INTx error message
authorRakuram Eswaran <rakuram.e96@gmail.com>
Tue, 23 Dec 2025 18:40:03 +0000 (00:10 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 2 Mar 2026 22:18:20 +0000 (16:18 -0600)
The INTx devm_request_irq() failure path logs an incorrect IRQ number. The
printed 'irq' variable refers to a previous MDB interrupt mapping and does
not correspond to the INTx IRQ being requested.

Fix the error message to report pcie->intx_irq, which is the IRQ associated
with the failing request.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202512230112.AaiGqMWM-lkp@intel.com/
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Rakuram Eswaran <rakuram.e96@gmail.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Sai Krishna Musham <sai.krishna.musham@amd.com>
Link: https://patch.msgid.link/20251223184003.32950-1-rakuram.e96@gmail.com
drivers/pci/controller/dwc/pcie-amd-mdb.c

index 3c6e837465bb7bf97bfe2a0471d396f9ebfb0e04..7e50e11fbffda24400ad46ea76738f725c8f2053 100644 (file)
@@ -389,7 +389,7 @@ static int amd_mdb_setup_irq(struct amd_mdb_pcie *pcie,
                               IRQF_NO_THREAD, NULL, pcie);
        if (err) {
                dev_err(dev, "Failed to request INTx IRQ %d, err=%d\n",
-                       irq, err);
+                       pcie->intx_irq, err);
                return err;
        }