]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
three more cases where maybe we want to exclude
authorRoger Dingledine <arma@torproject.org>
Fri, 11 Mar 2011 11:19:15 +0000 (06:19 -0500)
committerNick Mathewson <nickm@torproject.org>
Wed, 27 Apr 2011 03:54:15 +0000 (23:54 -0400)
src/or/circuitbuild.c
src/or/router.c

index b8a82e886ebd4665011ef816f1e92563a4c5e57f..4fa87c018f59bc12a5a95713bf4124662be000a9 100644 (file)
@@ -4570,6 +4570,7 @@ launch_direct_bridge_descriptor_fetch(bridge_info_t *bridge)
     return; /* it's already on the way */
 
   address = tor_dup_addr(&bridge->addr);
+  /* XXX022-1090 if we ExcludeNodes this bridge, should this step fail? -RD */
   directory_initiate_command(address, &bridge->addr,
                              bridge->port, 0,
                              0, /* does not matter */
index c15b9b236ea3df5a58788abda439deeafc4bf3cd..6993e1eb0aef491fb066cb34d00b5a127333b8f7 100644 (file)
@@ -857,6 +857,7 @@ consider_testing_reachability(int test_or, int test_dir)
     log_info(LD_CIRC, "Testing %s of my ORPort: %s:%d.",
              !orport_reachable ? "reachability" : "bandwidth",
              me->address, me->or_port);
+    /* XXX022-1090 If we ExcludeNodes ourself, should this fail? -RD */
     circuit_launch_by_router(CIRCUIT_PURPOSE_TESTING, me,
                              CIRCLAUNCH_NEED_CAPACITY|CIRCLAUNCH_IS_INTERNAL);
   }
@@ -867,6 +868,7 @@ consider_testing_reachability(int test_or, int test_dir)
                 CONN_TYPE_DIR, &addr, me->dir_port,
                 DIR_PURPOSE_FETCH_SERVERDESC)) {
     /* ask myself, via tor, for my server descriptor. */
+    /* XXX022-1090 If we ExcludeNodes ourself, should this fail? -RD */
     directory_initiate_command(me->address, &addr,
                                me->or_port, me->dir_port,
                                0, /* does not matter */