3974. [bug] handle DH_compute_key() failure correctly in

                        openssldh_link.c. [RT #37477]

diff --git a/CHANGES b/CHANGES
index aed11c827515d467b8d1066505b9b5189a57f093..57cab98885e383fe2146f93946ea3c9cd7c1b58e 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3974.  [bug]           handle DH_compute_key() failure correctly in
+                       openssldh_link.c. [RT #37477]
+
 3973.  [func]          Added hooks for Google/Great Performance Tools
                        CPU Profiler, including in real time. [RT #37339]
 

diff --git a/lib/dns/openssldh_link.c b/lib/dns/openssldh_link.c
index 6c3f555f8dc71b75d2b7a1bbfcc1eb9fdddd1995..2056394e03cbac20fcb04f47d348ef2262941e34 100644 (file)
--- a/lib/dns/openssldh_link.c
+++ b/lib/dns/openssldh_link.c
@@ -93,7 +93,7 @@ openssldh_computesecret(const dst_key_t *pub, const dst_key_t *priv,
        if (r.length < len)
                return (ISC_R_NOSPACE);
        ret = DH_compute_key(r.base, dhpub->pub_key, dhpriv);
-       if (ret == 0)
+       if (ret <= 0)
                return (dst__openssl_toresult2("DH_compute_key",
                                               DST_R_COMPUTESECRETFAILURE));
        isc_buffer_add(secret, len);