]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli/auth: Remove unnecessary casts
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Wed, 9 Aug 2023 04:52:31 +0000 (16:52 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 21 Aug 2023 23:37:29 +0000 (23:37 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/auth/ntlm_check.c
libcli/auth/smbencrypt.c

index 3927dfa78366bce7a94f772f1f2783a059fe93cc..a2388706bcfb71c8b646e500dbf1e2ad93c7473e 100644 (file)
@@ -383,7 +383,7 @@ NTSTATUS ntlm_password_check(TALLOC_CTX *mem_ctx,
                if (lm_response->length && 
                    (convert_string_talloc(mem_ctx, CH_DOS, CH_UNIX, 
                                          lm_response->data, lm_response->length, 
-                                          (void *)&unix_pw, &converted_size))) {
+                                          &unix_pw, &converted_size))) {
                        if (E_deshash(unix_pw, client_lm.hash)) {
                                lm_ok = true;
                        } else {
index d525b373e868e6ea1bcec281e47aa2783b3c153b..73c696c95c18a23346aab9d1e6a541d821534245 100644 (file)
@@ -968,7 +968,7 @@ bool decode_pw_buffer(TALLOC_CTX *ctx,
                                   CH_UNIX,
                                   new_password.data,
                                   new_password.length,
-                                  (void *)pp_new_pwrd,
+                                  pp_new_pwrd,
                                   new_pw_len);
        data_blob_free(&new_password);
        if (!ok) {
@@ -1062,7 +1062,7 @@ bool decode_pwd_string_from_buffer514(TALLOC_CTX *mem_ctx,
                                   CH_UNIX,
                                   new_password.data,
                                   new_password.length,
-                                  (void *)&decoded_password->data,
+                                  &decoded_password->data,
                                   &decoded_password->length);
        data_blob_free(&new_password);
        if (!ok) {