]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
postgres_fdw: Fix thinko in comment for UserMappingPasswordRequired().
authorEtsuro Fujita <efujita@postgresql.org>
Fri, 27 Feb 2026 08:05:03 +0000 (17:05 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Fri, 27 Feb 2026 08:05:03 +0000 (17:05 +0900)
This commit also rephrases this comment to improve readability.

Oversight in commit 6136e94dc.

Reported-by: Etsuro Fujita <etsuro.fujita@gmail.com>
Author: Andreas Karlsson <andreas@proxel.se>
Co-authored-by: Etsuro Fujita <etsuro.fujita@gmail.com>
Discussion: https://postgr.es/m/CAPmGK16pDnM_wU3kmquPj-M9MYqG3y0BdntRZ0eytqbCaFY3WQ%40mail.gmail.com
Backpatch-through: 14

contrib/postgres_fdw/connection.c

index 2fc52b81e13ddb200021a050d5fb068882f331b5..0f4249a97a080ae522e8e205eb351b6bc5e158de 100644 (file)
@@ -596,8 +596,9 @@ disconnect_pg_server(ConnCacheEntry *entry)
 }
 
 /*
- * Return true if the password_required is defined and false for this user
- * mapping, otherwise false. The mapping has been pre-validated.
+ * Check and return the value of password_required, if defined; otherwise,
+ * return true, which is the default value of it.  The mapping has been
+ * pre-validated.
  */
 static bool
 UserMappingPasswordRequired(UserMapping *user)