]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove workarounds for dnspython < 2.7.0
authorMichał Kępień <michal@isc.org>
Thu, 21 May 2026 09:52:56 +0000 (11:52 +0200)
committerMichał Kępień <michal@isc.org>
Thu, 21 May 2026 10:02:20 +0000 (12:02 +0200)
dnspython 2.7.0 is now required to run the BIND 9 system test suite.
Drop the workarounds for older dnspython versions as they are now
redundant.

(cherry picked from commit c9ceb191e8e45c461b8f03e853bef0d9f0eb403f)

bin/tests/system/cookie/cookie_ans.py
bin/tests/system/resend_loop/ans3/ans.py

index 3b6f0406f2af4061d5683167d1e791166b198e83..59f3d1fdf5278f13575337a49c9fa266ee5ffa3a 100644 (file)
@@ -44,12 +44,8 @@ def _add_cookie(qctx: QueryContext) -> None:
     for o in qctx.query.options:
         if o.otype == dns.edns.OptionType.COOKIE:
             cookie = o
-            try:
-                if len(cookie.server) == 0:
-                    cookie.server = cookie.client
-            except AttributeError:  # dnspython<2.7.0 compat
-                if len(o.data) == 8:
-                    cookie.data *= 2
+            if len(cookie.server) == 0:
+                cookie.server = cookie.client
 
             qctx.response.use_edns(options=[cookie])
             return
index 94f986c8e7949029e119d637b595177d8f7c4289..1378dd7ea5294efaddae1430169db004a6ccd77b 100644 (file)
@@ -32,12 +32,8 @@ def _get_cookie(qctx: QueryContext):
     for o in qctx.query.options:
         if o.otype == dns.edns.OptionType.COOKIE:
             cookie = o
-            try:
-                if len(cookie.server) == 0:
-                    cookie.server = b"\x11\x22\x33\x44\x55\x66\x77\x88"
-            except AttributeError:  # dnspython<2.7.0 compat
-                if len(o.data) == 8:
-                    cookie.data *= 2
+            if len(cookie.server) == 0:
+                cookie.server = b"\x11\x22\x33\x44\x55\x66\x77\x88"
 
             return cookie