ITS#9324 syncrepl: don't wait forever in Refresh mode

Just poll for available data, same as Persist mode.
Clarify retry/return states from do_syncrep2

diff --git a/servers/slapd/syncrepl.c b/servers/slapd/syncrepl.c
index 8319a9877434a9b6a3b600195809b5e175ab9bcf..1a88cd6b91aa5cb09aa3ccd3ac5767d29f4d4f4a 100644 (file)
--- a/servers/slapd/syncrepl.c
+++ b/servers/slapd/syncrepl.c
@@ -1077,7 +1077,11 @@ compare_csns( struct sync_cookie *sc1, struct sync_cookie *sc2, int *which )
        return match;
 }
 
-#define        SYNC_PAUSED     -3
+#define SYNC_TIMEOUT   0
+#define SYNC_SHUTDOWN  -100
+#define SYNC_ERROR             -101
+#define SYNC_REPOLL            -102
+#define SYNC_PAUSED            -103
 
 static int
 do_syncrep2(
@@ -1099,14 +1103,13 @@ do_syncrep2(
 
        int                             m;
 
-       struct timeval *tout_p = NULL;
        struct timeval tout = { 0, 0 };
 
        int             refreshDeletes = 0;
        char empty[6] = "empty";
 
        if ( slapd_shutdown ) {
-               rc = -2;
+               rc = SYNC_SHUTDOWN;
                goto done;
        }
 
@@ -1117,14 +1120,8 @@ do_syncrep2(
 
        slap_dup_sync_cookie( &syncCookie_req, &si->si_syncCookie );
 
-       if ( abs(si->si_type) == LDAP_SYNC_REFRESH_AND_PERSIST && si->si_refreshDone ) {
-               tout_p = &tout;
-       } else {
-               tout_p = NULL;
-       }
-
        while ( ( rc = ldap_result( si->si_ld, si->si_msgid, LDAP_MSG_ONE,
-               tout_p, &msg ) ) > 0 )
+               &tout, &msg ) ) > 0 )
        {
                int                             match, punlock, syncstate;
                struct berval   *retdata, syncUUID[2], cookie = BER_BVNULL;
@@ -1137,7 +1134,7 @@ do_syncrep2(
                struct berval   bdn;
 
                if ( slapd_shutdown ) {
-                       rc = -2;
+                       rc = SYNC_SHUTDOWN;
                        goto done;
                }
                switch( ldap_msgtype( msg ) ) {
@@ -1292,7 +1289,7 @@ do_syncrep2(
                                                /* check pending CSNs too */
                                                while ( ldap_pvt_thread_mutex_trylock( &si->si_cookieState->cs_pmutex )) {
                                                        if ( slapd_shutdown ) {
-                                                               rc = -2;
+                                                               rc = SYNC_SHUTDOWN;
                                                                goto done;
                                                        }
                                                        if ( !ldap_pvt_thread_pool_pausecheck( &connection_pool ))
@@ -1448,7 +1445,7 @@ logerr:
                                                si->si_refreshDone = 1;
                                                rc = LDAP_SYNC_REFRESH_REQUIRED;
                                        } else {
-                                               rc = -2;
+                                               rc = SYNC_REPOLL;
                                        }
                                }
                                goto done;
@@ -1459,7 +1456,7 @@ logerr:
                                if ( si->si_ctype == MSAD_DIRSYNC ) {
                                        rc = syncrepl_dirsync_cookie( si, op, rctrls );
                                        if ( rc == LDAP_SUCCESS )
-                                               rc = -2;        /* schedule a re-poll */
+                                               rc = SYNC_REPOLL;       /* schedule a re-poll */
                                        goto done;
                                }
 #endif
@@ -1477,7 +1474,7 @@ logerr:
                                                "got search result with multiple "
                                                "Sync State control\n", si->si_ridtxt );
                                        ldap_controls_free( rctrls );
-                                       rc = -1;
+                                       rc = SYNC_ERROR;
                                        goto done;
                                }
                        }
@@ -1548,7 +1545,11 @@ logerr:
                                rc = LDAP_SYNC_REFRESH_REQUIRED;
                                slap_resume_listeners();
                        } else {
-                               rc = -2;
+                               /* for persist, we shouldn't get a SearchResult so this is an error */
+                               if ( si->si_type == LDAP_SYNC_REFRESH_AND_PERSIST )
+                                       rc = SYNC_ERROR;
+                               else
+                                       rc = SYNC_REPOLL;
                        }
                        goto done;
 
@@ -1628,9 +1629,6 @@ logerr:
                                                Debug( LDAP_DEBUG_SYNC, "do_syncrep1: %s finished refresh\n",
                                                        si->si_ridtxt );
                                        }
-                                       if ( abs(si->si_type) == LDAP_SYNC_REFRESH_AND_PERSIST &&
-                                               si->si_refreshDone )
-                                               tout_p = &tout;
                                        break;
                                case LDAP_TAG_SYNC_ID_SET:
                                        Debug( LDAP_DEBUG_SYNC,
@@ -1760,7 +1758,7 @@ logerr:
                }
        }
 
-       if ( rc == -1 ) {
+       if ( rc == SYNC_ERROR ) {
                rc = LDAP_OTHER;
                ldap_get_option( si->si_ld, LDAP_OPT_ERROR_NUMBER, &rc );
                err = rc;
@@ -1803,7 +1801,7 @@ do_syncrepl(
        int rc = LDAP_SUCCESS;
        int dostop = 0;
        ber_socket_t s;
-       int i, defer = 1, fail = 0, freeinfo = 0;
+       int i, fail = 0, freeinfo = 0;
        Backend *be;
 
        if ( si == NULL )
@@ -1939,25 +1937,19 @@ deleted:
                        }
                        if ( si->si_conn )
                                dostop = 1;
-                       rc = -1;
+                       rc = SYNC_SHUTDOWN;
                }
 
                if ( rc != SYNC_PAUSED ) {
-                       if ( abs(si->si_type) == LDAP_SYNC_REFRESH_AND_PERSIST ) {
-                               /* If we succeeded, enable the connection for further listening.
-                                * If we failed, tear down the connection and reschedule.
-                                */
-                               if ( rc == LDAP_SUCCESS ) {
-                                       if ( si->si_conn ) {
-                                               connection_client_enable( si->si_conn );
-                                       } else {
-                                               si->si_conn = connection_client_setup( s, do_syncrepl, arg );
-                                       } 
-                               } else if ( si->si_conn ) {
-                                       dostop = 1;
+                       if ( rc == SYNC_TIMEOUT ) {
+                               /* there was nothing to read, try to listen for more */
+                               if ( si->si_conn ) {
+                                       connection_client_enable( si->si_conn );
+                               } else {
+                                       si->si_conn = connection_client_setup( s, do_syncrepl, arg );
                                }
-                       } else {
-                               if ( rc == -2 ) rc = 0;
+                       } else if ( si->si_conn ) {
+                               dostop = 1;
                        }
                }
        }
@@ -1966,8 +1958,8 @@ deleted:
         * 1) for any hard failure, give up and remove this task
         * 2) for ServerDown, reschedule this task to run later
         * 3) for threadpool pause, reschedule to run immediately
-        * 4) for Refresh and Success, reschedule to run
-        * 5) for Persist and Success, reschedule to defer
+        * 4) for SYNC_REPOLL, reschedule to run later
+        * 5) for SYNC_TIMEOUT, reschedule to defer
         */
        ldap_pvt_thread_mutex_lock( &slapd_rq.rq_mutex );
 
@@ -1985,29 +1977,26 @@ deleted:
                ldap_pvt_runqueue_resched( &slapd_rq, rtask, 0 );
                rtask->interval.tv_sec = si->si_interval;
                rc = 0;
-       } else if ( rc == LDAP_SUCCESS ) {
-               if ( si->si_type == LDAP_SYNC_REFRESH_ONLY
-#ifdef LDAP_CONTROL_X_DIRSYNC
-                       || si->si_type == MSAD_DIRSYNC
-#endif
-               ) {
-                       defer = 0;
-               }
+       } else if ( rc == SYNC_TIMEOUT ) {
+               ldap_pvt_runqueue_resched( &slapd_rq, rtask, 1 );
+       } else if ( rc == SYNC_REPOLL ) {
                rtask->interval.tv_sec = si->si_interval;
-               ldap_pvt_runqueue_resched( &slapd_rq, rtask, defer );
+               ldap_pvt_runqueue_resched( &slapd_rq, rtask, 0 );
                if ( si->si_retrynum ) {
                        for ( i = 0; si->si_retrynum_init[i] != RETRYNUM_TAIL; i++ ) {
                                si->si_retrynum[i] = si->si_retrynum_init[i];
                        }
                        si->si_retrynum[i] = RETRYNUM_TAIL;
                }
+               slap_wake_listener();
+               rc = 0;
        } else {
                for ( i = 0; si->si_retrynum && si->si_retrynum[i] <= 0; i++ ) {
                        if ( si->si_retrynum[i] == RETRYNUM_FOREVER || si->si_retrynum[i] == RETRYNUM_TAIL )
                                break;
                }
 
-               if ( si->si_ctype < 1
+               if ( si->si_ctype < 1 || rc == SYNC_SHUTDOWN
                        || !si->si_retrynum || si->si_retrynum[i] == RETRYNUM_TAIL ) {
                        if ( si->si_re ) {
                                ldap_pvt_runqueue_remove( &slapd_rq, rtask );