CI: Wrap all `if:` conditions in `${{ }}`

While `if:` also works with a bare condition, it is a best practice to always
wrap "dynamic placeholders" in `${{ }}`.

See: https://github.blog/changelog/2026-01-29-github-actions-smarter-editing-clearer-debugging-and-a-new-case-function/#better-if-condition-handling

diff --git a/.github/actions/setup-vtest/action.yml b/.github/actions/setup-vtest/action.yml
index 2b986ae746283d7326aefb55dd724d6bd5ae86a4..0cc963f0f3cf3c0883d6887dab36db899fb32c73 100644 (file)
--- a/.github/actions/setup-vtest/action.yml
+++ b/.github/actions/setup-vtest/action.yml
@@ -34,7 +34,7 @@ runs:
         key: vtest-${{ runner.os }}-${{ runner.arch }}-${{ steps.vtest-sha.outputs.sha }}
 
     - name: Install VTest
-      if: steps.cache-vtest.outputs.cache-hit != 'true'
+      if: ${{ steps.cache-vtest.outputs.cache-hit != 'true' }}
       shell: bash
       run: |
         DESTDIR=${{ github.workspace }}/vtest scripts/build-vtest.sh

diff --git a/.github/workflows/quic-interop-aws-lc.yml b/.github/workflows/quic-interop-aws-lc.yml
index a6e82788d07075e873e3b19048afde87cdfb41b4..0f5ee95801ef2f4eb6a45bf7b6aeb6d3200ca33f 100644 (file)
--- a/.github/workflows/quic-interop-aws-lc.yml
+++ b/.github/workflows/quic-interop-aws-lc.yml
@@ -49,7 +49,7 @@ jobs:
           python run.py -j result.json -l logs-ngtcp2 -r haproxy=local:aws-lc -t "handshake,transfer,longrtt,chacha20,multiplexing,retry,resumption,zerortt,http3,blackhole,keyupdate,ecn,amplificationlimit,handshakeloss,transferloss,handshakecorruption,transfercorruption,ipv6,v2" -c ngtcp2 -s haproxy
 
       - name: Delete succeeded logs
-        if: failure()
+        if: ${{ failure() }}
         run: |
           for client in chrome picoquic quic-go ngtcp2; do
             pushd quic-interop-runner/logs-${client}/haproxy_${client}
@@ -58,7 +58,7 @@ jobs:
           done
 
       - name: Logs upload
-        if: failure()
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: logs

diff --git a/.github/workflows/quic-interop-libressl.yml b/.github/workflows/quic-interop-libressl.yml
index c40564709dd8869c86ef407ab14baa89b8fc6e07..b9fdcee0bcfb9d408c5d8b118ef63b7091838306 100644 (file)
--- a/.github/workflows/quic-interop-libressl.yml
+++ b/.github/workflows/quic-interop-libressl.yml
@@ -47,7 +47,7 @@ jobs:
           python run.py -j result.json -l logs-quic-go -r haproxy=local:libressl -t "handshake,transfer,longrtt,chacha20,multiplexing,retry,http3,blackhole,amplificationlimit,transferloss,transfercorruption,v2" -c quic-go -s haproxy
 
       - name: Delete succeeded logs
-        if: failure()
+        if: ${{ failure() }}
         run: |
           for client in picoquic quic-go; do
             pushd quic-interop-runner/logs-${client}/haproxy_${client}
@@ -56,7 +56,7 @@ jobs:
           done
 
       - name: Logs upload
-        if: failure()
+        if: ${{ failure() }}
         uses: actions/upload-artifact@v4
         with:
           name: logs