]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Work around an OpenBSD "make" quirk
authorMichał Kępień <michal@isc.org>
Tue, 15 Oct 2019 14:38:04 +0000 (16:38 +0200)
committerMichał Kępień <michal@isc.org>
Tue, 15 Oct 2019 14:38:36 +0000 (16:38 +0200)
Consider the following Makefile:

    foo:
     false

On OpenBSD, the following happens for this Makefile:

  - "make foo" returns 1,
  - "make -k foo" returns 0,
  - "make -k -j6 foo" returns 1.

However, if the .NOTPARALLEL pseudo-target is added to this Makefile,
"make -k -j6 foo" will return 0 as well.

Since bin/tests/Makefile contains the .NOTPARALLEL pseudo-target,
running "make -k -j6 test" from bin/tests/ on OpenBSD prevents any
errors from being reported through that command's exit code.

Work around the issue by running "make -k -j6 test" in the
bin/tests/system/ directory instead as bin/tests/system/Makefile does
not contain the .NOTPARALLEL pseudo-target and thus things work as
expected there.

(cherry picked from commit 6b5426e1a7e19e4e39848a362c3dce80b40243b9)

.gitlab-ci.yml

index 855651c1f8078027e027109006949ef1995da022..b7945f9a51fc806f5269663570a63a61ce4215ff 100644 (file)
@@ -187,7 +187,7 @@ stages:
     - *setup_interfaces
     - *setup_softhsm
   script:
-    - ( cd bin/tests && make -j${TEST_PARALLEL_JOBS:-1} -k test V=1 )
+    - ( cd bin/tests/system && make -j${TEST_PARALLEL_JOBS:-1} -k test V=1 )
     - test -s bin/tests/system/systests.output
   artifacts:
     untracked: true