]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: phy: broadcom: Add power down exit reset state delay
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 11 Mar 2021 04:53:42 +0000 (20:53 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:30:19 +0000 (14:30 +0200)
[ Upstream commit 7a1468ba0e02eee24ae1353e8933793a27198e20 ]

Per the datasheet, when we clear the power down bit, the PHY remains in
an internal reset state for 40us and then resume normal operation.
Account for that delay to avoid any issues in the future if
genphy_resume() changes.

Fixes: fe26821fa614 ("net: phy: broadcom: Wire suspend/resume for BCM54810")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/broadcom.c

index 8a4ec3222168c3fc5d5f0612dbfcc336d7a9a937..ec45a1608309245531b863c657663f70dcdff5c1 100644 (file)
@@ -332,6 +332,11 @@ static int bcm54xx_resume(struct phy_device *phydev)
        if (ret < 0)
                return ret;
 
+       /* Upon exiting power down, the PHY remains in an internal reset state
+        * for 40us
+        */
+       fsleep(40);
+
        return bcm54xx_config_init(phydev);
 }