Input: libps2 - embed WARN_ON(1) macros into their enclosing if statements

Make WARN_ON(1) statements embedded inside their respective 'if' expressions,
to improve code clarity.

Signed-off-by: Max Brener <linmaxi@gmail.com>
Link: https://patch.msgid.link/20260214203725.6463-1-linmaxi@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/serio/libps2.c b/drivers/input/serio/libps2.c
index 269df83a167d9f7eaf639971358fafaaf8982f3f..05b64277aecd9cb916f74a86fb2def4811ccffa0 100644 (file)
--- a/drivers/input/serio/libps2.c
+++ b/drivers/input/serio/libps2.c
@@ -154,10 +154,8 @@ EXPORT_SYMBOL(ps2_end_command);
  */
 void ps2_drain(struct ps2dev *ps2dev, size_t maxbytes, unsigned int timeout)
 {
-       if (maxbytes > sizeof(ps2dev->cmdbuf)) {
-               WARN_ON(1);
+       if (WARN_ON(maxbytes > sizeof(ps2dev->cmdbuf)))
                maxbytes = sizeof(ps2dev->cmdbuf);
-       }
 
        ps2_begin_command(ps2dev);
 
@@ -270,15 +268,11 @@ int __ps2_command(struct ps2dev *ps2dev, u8 *param, unsigned int command)
        int i;
        u8 send_param[16];
 
-       if (receive > sizeof(ps2dev->cmdbuf)) {
-               WARN_ON(1);
+       if (WARN_ON(receive > sizeof(ps2dev->cmdbuf)))
                return -EINVAL;
-       }
 
-       if (send && !param) {
-               WARN_ON(1);
+       if (WARN_ON(send && !param))
                return -EINVAL;
-       }
 
        memcpy(send_param, param, send);