]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
_gnutls_retrieve_pin: remove array declarator in function argument
authorDaiki Ueno <ueno@gnu.org>
Tue, 11 May 2021 09:04:54 +0000 (11:04 +0200)
committerDaiki Ueno <ueno@gnu.org>
Tue, 11 May 2021 11:20:36 +0000 (13:20 +0200)
This was originally to eliminate the warnings with -Warray-parameter:

  pin.c:70:27: warning: argument 5 of type 'char[256]' with mismatched bound [-Warray-parameter=]
     70 |                      char pin[GNUTLS_PKCS11_MAX_PIN_LEN], unsigned pin_size)
        |                      ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  In file included from pin.c:23:
  ./pin.h:9:48: note: previously declared as 'char *'
      9 |                      unsigned pin_flags, char *pin, unsigned pin_size);
        |                                          ~~~~~~^~~

though it turned out to be unnecessary because the function merely
delegate the call to the user-supplied callbacks.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
lib/pin.c

index 13069c5e1933ce107a192f18ba4747718ac36f37..2c6f06ee2cb963cc469c607d6141e60f2507eb9b 100644 (file)
--- a/lib/pin.c
+++ b/lib/pin.c
@@ -67,7 +67,7 @@ gnutls_pin_callback_t gnutls_pkcs11_get_pin_function(void **userdata)
 int
 _gnutls_retrieve_pin(struct pin_info_st *pin_info, const char *url, const char *label,
                     unsigned flags,
-                    char pin[GNUTLS_PKCS11_MAX_PIN_LEN], unsigned pin_size)
+                    char *pin, unsigned pin_size)
 {
        int ret;