]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ethtool: tsconfig: fix missing ethnl_ops_complete()
authorJakub Kicinski <kuba@kernel.org>
Tue, 26 May 2026 15:35:28 +0000 (08:35 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 28 May 2026 00:42:08 +0000 (17:42 -0700)
tsconfig_prepare_data() calls ethnl_ops_begin(), we need to call
ethnl_ops_complete() before returning the error.

Fixes: 6e9e2eed4f39 ("net: ethtool: Add support for tsconfig command to get/set hwtstamp config")
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://patch.msgid.link/20260526153533.2779187-6-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/tsconfig.c

index e9db4ee2299df777b88aea49c596411cf1a5e5b9..fc4f93cfa459d39447d6b560166592c91151cbd4 100644 (file)
@@ -69,8 +69,10 @@ static int tsconfig_prepare_data(const struct ethnl_req_info *req_base,
                if (ret)
                        goto out;
 
-               if (ts_info.phc_index == -1)
-                       return -ENODEV;
+               if (ts_info.phc_index == -1) {
+                       ret = -ENODEV;
+                       goto out;
+               }
 
                data->hwprov_desc.index = ts_info.phc_index;
                data->hwprov_desc.qualifier = ts_info.phc_qualifier;