fix tags ci

diff --git a/.ci/test_font_tags.py b/.ci/test_font_tags.py
index fb980290ccfaf002bc1e4bd1eaada5975357df6c..d5b98ed7a0de6916f0f0afbe9cbd4c5fc6d8f210 100644 (file)
--- a/.ci/test_font_tags.py
+++ b/.ci/test_font_tags.py
@@ -1,22 +1,18 @@
 import pytest
 import json
-from urllib.request import urlopen
+import requests
 import csv
 import os
 
 @pytest.fixture
 def family_metadata():
-    data = json.loads(
-        urlopen("https://fonts.google.com/metadata/fonts").read().decode("utf-8")
-    )
+    data = requests.get("https://fonts.google.com/metadata/fonts").json()
     return data["familyMetadataList"]
 
 
 @pytest.fixture
 def sb_family_metadata():
-    data = json.loads(
-        urlopen("https://fonts.sandbox.google.com/metadata/fonts").read().decode("utf-8")
-    )
+    data = requests.get("https://fonts.sandbox.google.com/metadata/fonts").json()
     return data["familyMetadataList"]
 
 
@@ -34,13 +30,9 @@ def family_tags():
 
 @pytest.fixture
 def tags_metadata():
-    data = (
-        urlopen(
-            "https://raw.githubusercontent.com/google/fonts/main/tags/tags_metadata.csv"
-        )
-        .read()
-        .decode("utf-8")
-    )
+    data = requests.get(
+        "https://raw.githubusercontent.com/google/fonts/main/tags/tags_metadata.csv"
+    ).text
     reader = csv.reader(data.splitlines())
     res = []
     for category, _, _, _ in reader:
@@ -76,7 +68,7 @@ def test_no_duplicate_families(family_tags):
     seen = set()
     dups = []
     for family, axes, cat, _ in family_tags:
-        key = (family, cat)
+        key = (family, axes, cat)
         if key in seen:
             dups.append(",".join(key))
         seen.add(key)

diff --git a/.github/workflows/font_tags.yaml b/.github/workflows/font_tags.yaml
index f96dca4a419fb4c58893a4af65ee615bdb6c01df..abe3961c77615b8a403a084be58393261d9f97ba 100644 (file)
--- a/.github/workflows/font_tags.yaml
+++ b/.github/workflows/font_tags.yaml
@@ -21,7 +21,7 @@ jobs:
         python-version: "3.10"
 
     - name: Install dependencies
-      run: pip install pytest
+      run: pip install pytest requests
     - name: Check font tags
       run: |
         pytest .ci/test_font_tags.py
\ No newline at end of file