]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Drop "before_script" key from TSAN job definitions
authorMichał Kępień <michal@isc.org>
Thu, 26 Mar 2020 10:03:52 +0000 (11:03 +0100)
committerMichał Kępień <michal@isc.org>
Thu, 26 Mar 2020 10:45:38 +0000 (11:45 +0100)
Both "system_test_job" and "unit_test_job" YAML anchors contain a
"before_script" key.  TSAN job definitions first specify their own value
of the "before_script" key and then include the aforementioned YAML
anchors, which results in the value of the "before_script" key being
overridden with the value specified by the included anchor.  Given this,
remove "before_script" definitions specific to TSAN jobs as they serve
no practical purpose.

(cherry picked from commit 8ef01c7b50d9700f81f4836657a62ccf80b91ac7)

.gitlab-ci.yml

index 24c9693ed746aab651e775300ad088d6f781ed9a..589ddea5cd2af8df1bfe3701798688e2d507fda1 100644 (file)
@@ -916,9 +916,6 @@ gcc:tsan:
 system:gcc:tsan:
   variables:
     TSAN_OPTIONS: ${TSAN_OPTIONS_COMMON}
-  before_script:
-    - *setup_interfaces
-    - echo $TSAN_OPTIONS
   <<: *base_image
   <<: *system_test_job
   needs:
@@ -938,9 +935,6 @@ system:gcc:tsan:
 unit:gcc:tsan:
   variables:
     TSAN_OPTIONS: ${TSAN_OPTIONS_COMMON}
-  before_script:
-    - echo $TSAN_OPTIONS
-    - lib/isc/tests/result_test
   <<: *base_image
   <<: *unit_test_job
   needs:
@@ -971,9 +965,6 @@ clang:tsan:
 system:clang:tsan:
   variables:
     TSAN_OPTIONS: ${TSAN_OPTIONS_COMMON}
-  before_script:
-    - *setup_interfaces
-    - echo $TSAN_OPTIONS
   <<: *base_image
   <<: *system_test_job
   needs:
@@ -993,9 +984,6 @@ system:clang:tsan:
 unit:clang:tsan:
   variables:
     TSAN_OPTIONS: ${TSAN_OPTIONS_COMMON}
-  before_script:
-    - echo $TSAN_OPTIONS
-    - lib/isc/tests/result_test
   <<: *base_image
   <<: *unit_test_job
   needs: