2551. [bug] Potential Reference leak on return. [RT #19341]

diff --git a/CHANGES b/CHANGES
index d24af2d50fd75b08e50d90deac5643922507fd09..ea31505f52037f68d4fe578b3d88784043c4dddb 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+2551.  [bug]           Potential Reference leak on return. [RT #19341]
+
 2550.  [bug]           Check --with-openssl=<path> finds <openssl/opensslv.h>.
                        [RT #19343]
 

diff --git a/bin/named/query.c b/bin/named/query.c
index e8f9b68d93f0c18a56e595bd0fcf93cdca21f6f5..7109a62b7e791f1c813bfbf000fc5ea8f7b3f5ed 100644 (file)
--- a/bin/named/query.c
+++ b/bin/named/query.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: query.c,v 1.257.18.49 2009/01/19 23:46:14 tbox Exp $ */
+/* $Id: query.c,v 1.257.18.50 2009/02/15 23:08:14 marka Exp $ */
 
 /*! \file */
 
@@ -3292,8 +3292,7 @@ warn_rfc1918(ns_client_t *client, dns_name_t *fname, dns_rdataset_t *rdataset) {
                        RUNTIME_CHECK(result == ISC_R_SUCCESS);
                        dns_rdataset_current(&found, &rdata);
                        result = dns_rdata_tostruct(&rdata, &soa, NULL);
-                       if (result != ISC_R_SUCCESS)
-                               return;
+                       RUNTIME_CHECK(result == ISC_R_SUCCESS);
                        if (dns_name_equal(&soa.origin, &prisoner) &&
                            dns_name_equal(&soa.contact, &hostmaster)) {
                                char buf[DNS_NAME_FORMATSIZE];