]> git.ipfire.org Git - thirdparty/kmod.git/commitdiff
testsuite: Fix memory leak in test_export_environ error paths
authorjared mauch <jared@puck.nether.net>
Thu, 12 Feb 2026 13:54:14 +0000 (13:54 +0000)
committerLucas De Marchi <demarchi@kernel.org>
Wed, 18 Feb 2026 15:00:12 +0000 (09:00 -0600)
[emil: split from larger patch, commit message]
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Lucas De Marchi <demarchi@kernel.org>
Link: https://github.com/kmod-project/kmod/pull/423
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>
testsuite/testsuite.c

index 76690675b7f7b2c36e0325255d38bb6a25cf83e7..11a704f59dc97aa6a78e0b2eeb0c93e68f3cfea3 100644 (file)
@@ -188,6 +188,7 @@ static void test_export_environ(const struct test *t)
                tmp = realloc(preload, preloadlen + 2 + ldpreloadlen);
                if (tmp == NULL) {
                        ERR("oom: test_export_environ()\n");
+                       free(preload);
                        return;
                }
                preload = tmp;
@@ -208,6 +209,7 @@ static void test_export_environ(const struct test *t)
                        tmp = malloc(preloadlen + 2 + len);
                        if (tmp == NULL) {
                                ERR("oom: test_export_environ()\n");
+                               free(preload);
                                return;
                        }
                        memcpy(tmp, existing_preload, len);