qemuDomainManagedSaveDefineXML: Add top-level flag validation

The implementation for managed save uses 'qemuDomainSaveImageDefineXML'
internally which validates the flags. To have a top level flag
validation for the upcoming flag introspection export the supported
flags as a macro and add a 'virCheckFlags' to
'qemuDomainManagedSaveDefineXML'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 185d592fa781d05a00a2ca3cd394ff70cc1ec20a..e75d45140045808e8a785b2186b082c48428323e 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6126,6 +6126,11 @@ qemuDomainSaveImageGetXMLDesc(virConnectPtr conn, const char *path,
     return ret;
 }
 
+
+#define QEMU_SAVE_IMAGE_DEFINE_FLAGS \
+    VIR_DOMAIN_SAVE_RUNNING | \
+    VIR_DOMAIN_SAVE_PAUSED
+
 static int
 qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
                              const char *dxml, unsigned int flags)
@@ -6138,8 +6143,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
     virQEMUSaveData *data = NULL;
     int state = -1;
 
-    virCheckFlags(VIR_DOMAIN_SAVE_RUNNING |
-                  VIR_DOMAIN_SAVE_PAUSED, -1);
+    virCheckFlags(QEMU_SAVE_IMAGE_DEFINE_FLAGS, -1);
 
     if (flags & VIR_DOMAIN_SAVE_RUNNING)
         state = 1;
@@ -6249,6 +6253,8 @@ qemuDomainManagedSaveDefineXML(virDomainPtr dom, const char *dxml,
     g_autofree char *path = NULL;
     int ret = -1;
 
+    virCheckFlags(QEMU_SAVE_IMAGE_DEFINE_FLAGS, -1);
+
     if (!(vm = qemuDomainObjFromDomain(dom)))
         return -1;