]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Silence Coverity false positive
authorMark Andrews <marka@isc.org>
Wed, 3 Nov 2021 09:10:34 +0000 (20:10 +1100)
committerMark Andrews <marka@isc.org>
Wed, 3 Nov 2021 09:10:34 +0000 (20:10 +1100)
Coverity if failing to determine that 'priv.elements[i].length' is
actually valid when 'buf[i]' is non-NULL.  Initialise 'priv' to
zeros.

lib/dns/opensslrsa_link.c

index 2edf0c98c38fb685a0e8b45ef51796856ef0997d..34a882a3ef3beab02c207562690ed1e0099bde09 100644 (file)
@@ -790,7 +790,7 @@ err:
 static isc_result_t
 opensslrsa_tofile(const dst_key_t *key, const char *directory) {
        isc_result_t ret;
-       dst_private_t priv;
+       dst_private_t priv = { 0 };
        unsigned char *bufs[8] = { NULL };
        unsigned short i = 0;
        EVP_PKEY *pkey;
@@ -810,7 +810,6 @@ opensslrsa_tofile(const dst_key_t *key, const char *directory) {
        }
 
        if (key->external) {
-               priv.nelements = 0;
                return (dst__privstruct_writefile(key, &priv, directory));
        }