]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
TLSA: fix fromwire length checks
authorMark Andrews <marka@isc.org>
Thu, 13 Aug 2020 02:30:04 +0000 (12:30 +1000)
committerMark Andrews <marka@isc.org>
Thu, 13 Aug 2020 14:25:41 +0000 (00:25 +1000)
(cherry picked from commit 3429c35f52be9dfea69b96fda7d5b7fe804614a5)

lib/dns/rdata/generic/tlsa_52.c

index cb8b57a7429cb8cd221647fb80f4b53c73b3499e..0d5e3f909cec8e82efce8bbf88d65b4a980761a2 100644 (file)
@@ -122,8 +122,10 @@ generic_fromwire_tlsa(ARGS_FROMWIRE) {
 
        isc_buffer_activeregion(source, &sr);
 
-       if (sr.length < 3)
+       /* Usage(1), Selector(1), Type(1), Data(1+) */
+       if (sr.length < 4) {
                return (ISC_R_UNEXPECTEDEND);
+       }
 
        isc_buffer_forward(source, sr.length);
        return (mem_tobuffer(target, sr.base, sr.length));