]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: zynq: fix runtime PM leak on remove
authorRuoyu Wang <ruoyuw560@gmail.com>
Tue, 9 Jun 2026 07:33:13 +0000 (15:33 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Tue, 9 Jun 2026 11:19:13 +0000 (13:19 +0200)
pm_runtime_get_sync() increments the runtime PM usage counter even when it
returns an error. zynq_gpio_remove() uses it to keep the controller active
while removing the GPIO chip, but never drops the usage counter again.

Balance the get with pm_runtime_put_noidle() after disabling runtime PM.

Fixes: 3242ba117e9b ("gpio: Add driver for Zynq GPIO controller")
Signed-off-by: Ruoyu Wang <ruoyuw560@gmail.com>
Link: https://patch.msgid.link/20260609073313.5-1-ruoyuw560@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpio-zynq.c

index 571e366624d2af586bc4daa34fbe0e1738418c4f..fafca91128b2e6d6639828e09a6b1918489120f2 100644 (file)
@@ -1014,6 +1014,7 @@ static void zynq_gpio_remove(struct platform_device *pdev)
        gpiochip_remove(&gpio->chip);
        device_set_wakeup_capable(&pdev->dev, 0);
        pm_runtime_disable(&pdev->dev);
+       pm_runtime_put_noidle(&pdev->dev);
 }
 
 static struct platform_driver zynq_gpio_driver = {