]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Don't unroll the loop
authorWitold Kręcicki <wpk@isc.org>
Wed, 13 Nov 2019 12:40:01 +0000 (13:40 +0100)
committerWitold Kręcicki <wpk@isc.org>
Wed, 13 Nov 2019 12:40:01 +0000 (13:40 +0100)
lib/dns/name.c

index e751194478378f12797b3a908958b90889b821b9..94a88072b31401bf5d83176d2a3191be2ba60f55 100644 (file)
@@ -558,36 +558,6 @@ dns_name_fullcompare(const dns_name_t *name1, const dns_name_t *name2,
                else
                        count = count2;
 
-               /* Loop unrolled for performance */
-               while (ISC_LIKELY(count > 3)) {
-                       chdiff = (int)maptolower[label1[0]] -
-                                (int)maptolower[label2[0]];
-                       if (chdiff != 0) {
-                               *orderp = chdiff;
-                               goto done;
-                       }
-                       chdiff = (int)maptolower[label1[1]] -
-                                (int)maptolower[label2[1]];
-                       if (chdiff != 0) {
-                               *orderp = chdiff;
-                               goto done;
-                       }
-                       chdiff = (int)maptolower[label1[2]] -
-                                (int)maptolower[label2[2]];
-                       if (chdiff != 0) {
-                               *orderp = chdiff;
-                               goto done;
-                       }
-                       chdiff = (int)maptolower[label1[3]] -
-                                (int)maptolower[label2[3]];
-                       if (chdiff != 0) {
-                               *orderp = chdiff;
-                               goto done;
-                       }
-                       count -= 4;
-                       label1 += 4;
-                       label2 += 4;
-               }
                while (ISC_LIKELY(count-- > 0)) {
                        chdiff = (int)maptolower[*label1++] -
                                 (int)maptolower[*label2++];