]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Do not runtime check uv_tcp_close_reset
authorMatthijs Mekking <matthijs@isc.org>
Wed, 8 May 2024 07:27:53 +0000 (09:27 +0200)
committerMatthijs Mekking <matthijs@isc.org>
Mon, 3 Jun 2024 08:16:32 +0000 (08:16 +0000)
When we reset a TCP connection by sending a RST packet, do not bother
requiring the result is a success code.

(cherry picked from commit 5b94bb21295560aed8b3f1968fbfae261c57aab9)

lib/isc/netmgr/netmgr.c

index 44ef28e360c59adabd0f43c304e63ce8d17c824f..8ca1f8c1552ca7c7d4cca7b0ced32315ebcf74ad 100644 (file)
@@ -3014,7 +3014,12 @@ isc__nmsocket_reset(isc_nmsocket_t *sock) {
                isc__nmsocket_attach(sock, &(isc_nmsocket_t *){ NULL });
                int r = uv_tcp_close_reset(&sock->uv_handle.tcp,
                                           reset_shutdown);
-               UV_RUNTIME_CHECK(uv_tcp_close_reset, r);
+               if (r != 0) {
+                       isc_log_write(isc_lctx, ISC_LOGCATEGORY_GENERAL,
+                                     ISC_LOGMODULE_NETMGR, ISC_LOG_DEBUG(1),
+                                     "TCP Reset (RST) failed: %s",
+                                     uv_strerror(r));
+               }
        } else {
                isc__nmsocket_shutdown(sock);
        }