]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/exynos-combiner: Remove useless spinlock
authorMarek Szyprowski <m.szyprowski@samsung.com>
Fri, 22 May 2026 06:10:12 +0000 (08:10 +0200)
committerThomas Gleixner <tglx@kernel.org>
Wed, 3 Jun 2026 16:27:05 +0000 (18:27 +0200)
irq_controller_lock doesn't protect anything, it is a leftover from early
development or copy/paste. Remove it completely.

Fixes: 96031b31a4b3 ("irqchip/exynos-combiner: Switch to raw_spinlock")
Suggested-by: Thomas Gleixner <tglx@kernel.org>
Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/all/20260521090453.bbUZ00tS@linutronix.de
Link: https://patch.msgid.link/20260522061012.2687122-1-m.szyprowski@samsung.com/
drivers/irqchip/exynos-combiner.c

index 03cafcc5c8355d1b33dda9c4d7944f54b26cb853..d9d408cb4711e854bbc7583de86c62571cb0eea2 100644 (file)
@@ -24,8 +24,6 @@
 
 #define IRQ_IN_COMBINER                8
 
-static DEFINE_RAW_SPINLOCK(irq_controller_lock);
-
 struct combiner_chip_data {
        unsigned int hwirq_offset;
        unsigned int irq_mask;
@@ -72,9 +70,7 @@ static void combiner_handle_cascade_irq(struct irq_desc *desc)
 
        chained_irq_enter(chip, desc);
 
-       raw_spin_lock(&irq_controller_lock);
        status = readl_relaxed(chip_data->base + COMBINER_INT_STATUS);
-       raw_spin_unlock(&irq_controller_lock);
        status &= chip_data->irq_mask;
 
        if (status == 0)