]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: dac: ad7293: add dev variable
authorAntoniu Miclaus <antoniu.miclaus@analog.com>
Fri, 27 Feb 2026 14:01:38 +0000 (16:01 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 28 Feb 2026 11:35:23 +0000 (11:35 +0000)
Introduce a local struct device pointer in functions that reference
&spi->dev for device-managed resource calls and device property reads,
improving code readability.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad7293.c

index c3797e40cdd9f5f6335dd4d4b2fe52d56eb4075a..c86c54d53df1c706ca40d855c70547ed29893867 100644 (file)
@@ -776,27 +776,27 @@ static int ad7293_reset(struct ad7293_state *st)
 
 static int ad7293_properties_parse(struct ad7293_state *st)
 {
-       struct spi_device *spi = st->spi;
+       struct device *dev = &st->spi->dev;
        int ret;
 
-       ret = devm_regulator_get_enable(&spi->dev, "avdd");
+       ret = devm_regulator_get_enable(dev, "avdd");
        if (ret)
-               return dev_err_probe(&spi->dev, ret, "failed to enable AVDD\n");
+               return dev_err_probe(dev, ret, "failed to enable AVDD\n");
 
-       ret = devm_regulator_get_enable(&spi->dev, "vdrive");
+       ret = devm_regulator_get_enable(dev, "vdrive");
        if (ret)
-               return dev_err_probe(&spi->dev, ret, "failed to enable VDRIVE\n");
+               return dev_err_probe(dev, ret, "failed to enable VDRIVE\n");
 
-       ret = devm_regulator_get_enable_optional(&spi->dev, "vrefin");
+       ret = devm_regulator_get_enable_optional(dev, "vrefin");
        if (ret < 0 && ret != -ENODEV)
-               return dev_err_probe(&spi->dev, ret, "failed to enable VREFIN\n");
+               return dev_err_probe(dev, ret, "failed to enable VREFIN\n");
 
        st->vrefin_en = ret != -ENODEV;
 
-       st->gpio_reset = devm_gpiod_get_optional(&st->spi->dev, "reset",
+       st->gpio_reset = devm_gpiod_get_optional(dev, "reset",
                                                 GPIOD_OUT_HIGH);
        if (IS_ERR(st->gpio_reset))
-               return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_reset),
+               return dev_err_probe(dev, PTR_ERR(st->gpio_reset),
                                     "failed to get the reset GPIO\n");
 
        return 0;
@@ -845,9 +845,10 @@ static int ad7293_probe(struct spi_device *spi)
 {
        struct iio_dev *indio_dev;
        struct ad7293_state *st;
+       struct device *dev = &spi->dev;
        int ret;
 
-       indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
+       indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
        if (!indio_dev)
                return -ENOMEM;
 
@@ -867,7 +868,7 @@ static int ad7293_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       return devm_iio_device_register(&spi->dev, indio_dev);
+       return devm_iio_device_register(dev, indio_dev);
 }
 
 static const struct spi_device_id ad7293_id[] = {