]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: lenovo-wmi-other: Fix tunable_attr_01 struct members
authorDerek J. Clark <derekjohn.clark@gmail.com>
Sun, 10 May 2026 04:25:35 +0000 (04:25 +0000)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 11 May 2026 11:29:05 +0000 (14:29 +0300)
In struct tunable_attr_01 the capdata pointer is unused and the size of
the id members is u32 when it should be u8. Fix these prior to adding
additional members.

No functional change intended.

Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: stable@vger.kernel.org
Reviewed-by: Rong Zhang <i@rong.moe>
Tested-by: Rong Zhang <i@rong.moe>
Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
Link: https://patch.msgid.link/20260510042546.436874-6-derekjohn.clark@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/lenovo/wmi-other.c

index c1b429269f8913c182b2ef1f4470eaf8c76cb721..526075ff52d0690804eaf5caa898ce37827bb486 100644 (file)
@@ -548,11 +548,10 @@ out:
 /* ======== fw_attributes (component: lenovo-wmi-capdata 01) ======== */
 
 struct tunable_attr_01 {
-       struct capdata01 *capdata;
        struct device *dev;
-       u32 feature_id;
-       u32 device_id;
-       u32 type_id;
+       u8 feature_id;
+       u8 device_id;
+       u8 type_id;
 };
 
 static struct tunable_attr_01 ppt_pl1_spl = {