]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
netcmd: models: SDDLField move line down where it gets used
authorRob van der Linde <rob@catalyst.net.nz>
Mon, 12 Feb 2024 09:03:34 +0000 (22:03 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 16 Feb 2024 02:41:36 +0000 (02:41 +0000)
Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>
python/samba/netcmd/domain/models/fields.py

index 9a3a07569c778ed794bc2ddfa99d0a19e84014d1..d2a3b5e9d9e2408fe08cf2c28c53262d6126205b 100644 (file)
@@ -402,7 +402,6 @@ class SDDLField(Field):
             return ndr_unpack(security.descriptor, value[0])
 
     def to_db_value(self, ldb, value, flags):
-        domain_sid = security.dom_sid(ldb.get_domain_sid())
         if value is None:
             return
         elif isinstance(value, list):
@@ -411,6 +410,8 @@ class SDDLField(Field):
                 flags,
                 self.name)
         else:
+            domain_sid = security.dom_sid(ldb.get_domain_sid())
+
             # If this is a SDDL string convert it to a descriptor.
             if isinstance(value, str):
                 desc = security.descriptor.from_sddl(