]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: chipone-icn6211: use devm_drm_bridge_add in i2c probe
authorOsama Abdelkader <osama.abdelkader@gmail.com>
Thu, 30 Apr 2026 19:49:42 +0000 (21:49 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 19 May 2026 08:14:06 +0000 (10:14 +0200)
Use devm_drm_bridge_add() so the bridge is released if probe
fails after registration, and drop drm_bridge_remove() in chipone_i2c_probe.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support")
Cc: stable@vger.kernel.org
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Link: https://patch.msgid.link/20260430194944.78119-1-osama.abdelkader@gmail.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/chipone-icn6211.c

index 814713c5bea97dcdc2b847d2f266a567ef40e981..553a1df4688d0d41f3ff8fedf2c9feb8f7dae7ac 100644 (file)
@@ -758,7 +758,9 @@ static int chipone_i2c_probe(struct i2c_client *client)
        dev_set_drvdata(dev, icn);
        i2c_set_clientdata(client, icn);
 
-       drm_bridge_add(&icn->bridge);
+       ret = devm_drm_bridge_add(dev, &icn->bridge);
+       if (ret)
+               return ret;
 
        return chipone_dsi_host_attach(icn);
 }