Fix wrong datum conversion for subretentionactive in CreateSubscription.

Use BoolGetDatum() instead of Int32GetDatum() when storing the boolean
subretentionactive column in pg_subscription. This was an oversight in
a850be2fe6.

Author: Lakshmi N <lakshmin.jhs@gmail.com>
Reviewed-by: Nisha Moond <nisha.moond412@gmail.com>
Discussion: https://postgr.es/m/CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com

diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c
index d512e87cfe361ceda0c4995b8e00ab7c3794a00a..1e10d9d9a58c33037c4939827f30a390f05976d3 100644 (file)
--- a/src/backend/commands/subscriptioncmds.c
+++ b/src/backend/commands/subscriptioncmds.c
@@ -796,7 +796,7 @@ CreateSubscription(ParseState *pstate, CreateSubscriptionStmt *stmt,
        values[Anum_pg_subscription_submaxretention - 1] =
                Int32GetDatum(opts.maxretention);
        values[Anum_pg_subscription_subretentionactive - 1] =
-               Int32GetDatum(opts.retaindeadtuples);
+               BoolGetDatum(opts.retaindeadtuples);
        values[Anum_pg_subscription_subserver - 1] = ObjectIdGetDatum(serverid);
        if (!OidIsValid(serverid))
                values[Anum_pg_subscription_subconninfo - 1] =