]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix missing server socket detach in TLS accept error path
authorOndřej Surý <ondrej@isc.org>
Sat, 14 Mar 2026 11:54:27 +0000 (12:54 +0100)
committerOndřej Surý <ondrej@sury.org>
Mon, 16 Mar 2026 10:05:03 +0000 (11:05 +0100)
When TLS creation fails in tlslisten_acceptcb(), tlssock->server
was not detached before detaching tlssock itself.

(cherry picked from commit 2ab3d7c0757ef8dc3d7a979bad1443a9454e8f55)

lib/isc/netmgr/tlsstream.c

index 8d5fe1fd377320cf9e77123bb576d815b480c49b..2e5276b369f2a66d2212274d60597be53a790333 100644 (file)
@@ -935,6 +935,7 @@ tlslisten_acceptcb(isc_nmhandle_t *handle, isc_result_t result, void *cbarg) {
        if (tlssock->tlsstream.tls == NULL) {
                tlssock->closed = true;
                isc_tlsctx_free(&tlssock->tlsstream.ctx);
+               isc__nmsocket_detach(&tlssock->server);
                isc__nmsocket_detach(&tlssock);
                return ISC_R_TLSERROR;
        }