1762. [bug] isc_interfaceiter_create() could return ISC_R_SUCCESS

                        even when it failed. [RT #12995]

diff --git a/CHANGES b/CHANGES
index 402b4aafb306241590d68ec4f4526eb59f507be7..76b8c8d82645dfa5d4a030f8882d9c7c64c6d8f8 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -4,7 +4,8 @@
 
 1763.  [placeholder]   rt13002
 
-1762.  [placeholder]   rt12995
+1762.  [bug]           isc_interfaceiter_create() could return ISC_R_SUCCESS
+                       even when it failed. [RT #12995]
 
 1761.  [placeholder]   rt12971
 

diff --git a/lib/isc/unix/ifiter_ioctl.c b/lib/isc/unix/ifiter_ioctl.c
index 035f0b0e3bd8bcbd1cd274a4114b49ac9b804827..ba732043896f93d21b5ac3dd34015b5966088cf2 100644 (file)
--- a/lib/isc/unix/ifiter_ioctl.c
+++ b/lib/isc/unix/ifiter_ioctl.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: ifiter_ioctl.c,v 1.49 2004/06/22 05:25:49 marka Exp $ */
+/* $Id: ifiter_ioctl.c,v 1.50 2004/11/10 22:22:10 marka Exp $ */
 
 /*
  * Obtain the list of network interfaces using the SIOCGLIFCONF ioctl.
@@ -339,9 +339,8 @@ isc_interfaceiter_create(isc_mem_t *mctx, isc_interfaceiter_t **iterp) {
                        result = ISC_R_UNEXPECTED;
                        goto socket6_failure;
                }
-               iter->result6 = getbuf6(iter);
-               if (iter->result6 != ISC_R_NOTIMPLEMENTED &&
-                   iter->result6 != ISC_R_SUCCESS)
+               result = iter->result6 = getbuf6(iter);
+               if (result != ISC_R_NOTIMPLEMENTED && result != ISC_R_SUCCESS)
                        goto ioctl6_failure;
        }
 #endif