]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix keyfromlabel test, missing status update
authorMatthijs Mekking <matthijs@isc.org>
Fri, 4 Feb 2022 10:55:46 +0000 (11:55 +0100)
committerMatthijs Mekking <matthijs@isc.org>
Fri, 4 Feb 2022 12:40:18 +0000 (13:40 +0100)
Fix a missing status=$((status+ret)) in the keyfromlabel system test,
which would ignore the error if ZSK key creation failed.

bin/tests/system/keyfromlabel/tests.sh

index 247eefe688bd86d2dc3c88caf70800d5b65d5ff8..4f6940af7b628496a782d911f1e311cfa404bd10 100644 (file)
@@ -65,13 +65,14 @@ do
                ret=0
                zsk=$(keyfromlabel $alg $zone keyfromlabel-zsk)
                test -z "$zsk" && ret=1
+               test "$ret" -eq 0 || echo_i "failed (zsk=$zsk)"
+               status=$((status+ret))
 
                echo_i "Get KSK $alg $zone $type:$bits"
                ret=0
                ksk=$(keyfromlabel $alg $zone keyfromlabel-ksk -f KSK)
                test -z "$ksk" && ret=1
-
-               test "$ret" -eq 0 || echo_i "failed (zsk=$zsk ksk=$ksk)"
+               test "$ret" -eq 0 || echo_i "failed (ksk=$ksk)"
                status=$((status+ret))
 
                # Skip signing if dnssec-keyfromlabel failed.