Make delv use OS-supplied ephemeral port range

Make delv honor the operating system's preferred ephemeral port range
instead of always using the default 1024-65535 range for outgoing
messages.

(cherry picked from commit ada6846a10277e30655b76bd33ff2e54a3736524)

diff --git a/lib/dns/client.c b/lib/dns/client.c
index c5b9884086172f80663072235e7305f0c20a1531..bfea2971baef2058c9930d74f990c010f73b0a89 100644 (file)
--- a/lib/dns/client.c
+++ b/lib/dns/client.c
@@ -18,6 +18,7 @@
 #include <isc/buffer.h>
 #include <isc/mem.h>
 #include <isc/mutex.h>
+#include <isc/portset.h>
 #include <isc/safe.h>
 #include <isc/sockaddr.h>
 #include <isc/socket.h>
@@ -252,6 +253,48 @@ static isc_result_t request_soa(updatectx_t *uctx);
 static void client_resfind(resctx_t *rctx, dns_fetchevent_t *event);
 static isc_result_t send_update(updatectx_t *uctx);
 
+/*
+ * Try honoring the operating system's preferred ephemeral port range.
+ */
+static isc_result_t
+setsourceports(isc_mem_t *mctx, dns_dispatchmgr_t *manager) {
+       isc_portset_t *v4portset = NULL, *v6portset = NULL;
+       in_port_t udpport_low, udpport_high;
+       isc_result_t result;
+
+       result = isc_portset_create(mctx, &v4portset);
+       if (result != ISC_R_SUCCESS) {
+               goto cleanup;
+       }
+       result = isc_net_getudpportrange(AF_INET, &udpport_low, &udpport_high);
+       if (result != ISC_R_SUCCESS) {
+               goto cleanup;
+       }
+       isc_portset_addrange(v4portset, udpport_low, udpport_high);
+
+       result = isc_portset_create(mctx, &v6portset);
+       if (result != ISC_R_SUCCESS) {
+               goto cleanup;
+       }
+       result = isc_net_getudpportrange(AF_INET6, &udpport_low, &udpport_high);
+       if (result != ISC_R_SUCCESS) {
+               goto cleanup;
+       }
+       isc_portset_addrange(v6portset, udpport_low, udpport_high);
+
+       result = dns_dispatchmgr_setavailports(manager, v4portset, v6portset);
+
+ cleanup:
+       if (v4portset != NULL) {
+               isc_portset_destroy(mctx, &v4portset);
+       }
+       if (v6portset != NULL) {
+               isc_portset_destroy(mctx, &v6portset);
+       }
+
+       return (result);
+}
+
 static isc_result_t
 getudpdispatch(int family, dns_dispatchmgr_t *dispatchmgr,
               isc_socketmgr_t *socketmgr, isc_taskmgr_t *taskmgr,
@@ -483,6 +526,7 @@ dns_client_createx2(isc_mem_t *mctx, isc_appctx_t *actx,
        if (result != ISC_R_SUCCESS)
                goto cleanup;
        client->dispatchmgr = dispatchmgr;
+       (void)setsourceports(mctx, dispatchmgr);
 
        /*
         * If only one address family is specified, use it.