]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
_gnutls_cert_log: assume that 'cert' is nonnull
authorDaiki Ueno <ueno@gnu.org>
Thu, 12 Nov 2020 09:57:21 +0000 (10:57 +0100)
committerDaiki Ueno <ueno@gnu.org>
Thu, 19 Nov 2020 14:38:02 +0000 (15:38 +0100)
This makes static analyzers happy.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
lib/errors.h
lib/x509/ocsp.c

index 30ed744a49698d0a1af595fa4f89f14461901445..86c6b027656438310248cadff3280f376909ed22 100644 (file)
@@ -98,7 +98,7 @@ void _gnutls_mpi_log(const char *prefix, bigint_t a);
 
 #define _gnutls_cert_log(str, cert) \
        do { \
-               if (unlikely(_gnutls_log_level >= 3 && cert != NULL)) { \
+               if (unlikely(_gnutls_log_level >= 3)) { \
                        gnutls_datum_t _cl_out; int _cl_ret; \
                        _cl_ret = gnutls_x509_crt_print(cert, GNUTLS_CRT_PRINT_ONELINE, &_cl_out); \
                        if (_cl_ret >= 0) { \
index caa511e9db728ba98d2985cf781ffc4d5f40e516..3e179a8aa92af3c15ce282288a4ab81d926dce36 100644 (file)
@@ -2103,7 +2103,7 @@ _ocsp_resp_verify_direct(gnutls_ocsp_resp_const_t resp,
                goto done;
        }
 
-       _gnutls_cert_log("ocsp signer", signercert); \
+       _gnutls_cert_log("ocsp signer", signercert);
 
        rc = gnutls_pubkey_import_x509(pubkey, signercert, 0);
        if (rc != GNUTLS_E_SUCCESS) {