]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xfs: remove xfs_setup_existing_inode
authorChristoph Hellwig <hch@lst.de>
Fri, 15 May 2026 13:50:29 +0000 (15:50 +0200)
committerCarlos Maiolino <cem@kernel.org>
Tue, 9 Jun 2026 07:14:41 +0000 (09:14 +0200)
xfs_setup_existing_inode only has a single caller, fold it into that.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_icache.c
fs/xfs/xfs_inode.h

index d0bc8ea79d40f8e005933b0d1a42aaff502291a5..37caed10c089604bb555cfc976aae077187cd02c 100644 (file)
@@ -817,8 +817,11 @@ again:
         * now.  If it's a new inode being created, xfs_init_new_inode will
         * handle it.
         */
-       if (xfs_iflags_test(ip, XFS_INEW) && VFS_I(ip)->i_mode != 0)
-               xfs_setup_existing_inode(ip);
+       if (xfs_iflags_test(ip, XFS_INEW) && VFS_I(ip)->i_mode != 0) {
+               xfs_setup_inode(ip);
+               xfs_setup_iops(ip);
+               xfs_finish_inode_setup(ip);
+       }
        return 0;
 
 out_error_or_again:
index bd6d335571943d113b24173bc83daf930bab2623..724baea02c8d47753206e6180bfd8800de6e2354 100644 (file)
@@ -630,13 +630,6 @@ static inline void xfs_finish_inode_setup(struct xfs_inode *ip)
        unlock_new_inode(VFS_I(ip));
 }
 
-static inline void xfs_setup_existing_inode(struct xfs_inode *ip)
-{
-       xfs_setup_inode(ip);
-       xfs_setup_iops(ip);
-       xfs_finish_inode_setup(ip);
-}
-
 void xfs_irele(struct xfs_inode *ip);
 
 extern struct kmem_cache       *xfs_inode_cache;