]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: greybus: arche: use sysfs_emit() instead of sprintf()
authorRuslan Valiyev <linuxoid@gmail.com>
Thu, 26 Feb 2026 07:48:58 +0000 (07:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Mar 2026 16:02:59 +0000 (17:02 +0100)
Replace sprintf() with sysfs_emit() in state_show() sysfs attribute
callbacks in arche-platform.c and arche-apb-ctrl.c.

Checkpatch complains about code using sprintf(). This code here is
obviously safe as-is, but it would be more appropriate to use
sysfs_emit().

Signed-off-by: Ruslan Valiyev <linuxoid@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20260226074858.67635-1-linuxoid@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/arche-apb-ctrl.c

index 33f26a65f0cc063e6bc2ef1fa927f0928eb2696d..19a6e59b6d5c1dae41e11ce03b8dc4557afc5e7b 100644 (file)
@@ -300,16 +300,16 @@ static ssize_t state_show(struct device *dev,
 
        switch (apb->state) {
        case ARCHE_PLATFORM_STATE_OFF:
-               return sprintf(buf, "off%s\n",
+               return sysfs_emit(buf, "off%s\n",
                                apb->init_disabled ? ",disabled" : "");
        case ARCHE_PLATFORM_STATE_ACTIVE:
-               return sprintf(buf, "active\n");
+               return sysfs_emit(buf, "active\n");
        case ARCHE_PLATFORM_STATE_STANDBY:
-               return sprintf(buf, "standby\n");
+               return sysfs_emit(buf, "standby\n");
        case ARCHE_PLATFORM_STATE_FW_FLASHING:
-               return sprintf(buf, "fw_flashing\n");
+               return sysfs_emit(buf, "fw_flashing\n");
        default:
-               return sprintf(buf, "unknown state\n");
+               return sysfs_emit(buf, "unknown state\n");
        }
 }