]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: mdio: add 10G polling comment
authorMarkus Stockhausen <markus.stockhausen@gmx.de>
Sun, 3 May 2026 16:42:34 +0000 (18:42 +0200)
committerRobert Marko <robimarko@gmail.com>
Tue, 5 May 2026 11:12:17 +0000 (13:12 +0200)
Make clear that the hardware design always uses the same type
of 10G phys. So it is uncritical that the polling values are
overwritten multiple times.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Link: https://github.com/openwrt/openwrt/pull/23204
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/files-6.18/drivers/net/mdio/mdio-realtek-otto.c

index 6be60c9b42b84e12b6c3d9992ace74f4f7b91a51..9889b62e3ebd0979ffc963fd596a2774db8cd263 100644 (file)
@@ -792,7 +792,7 @@ static void rtmdio_930x_setup_polling(struct rtmdio_ctrl *ctrl)
                regmap_assign_bits(ctrl->map, RTMDIO_930X_SMI_PRVTE_POLLING_CTRL,
                                   BIT(pn), phyinfo.has_giga_lite);
 
-               /* special duplex/advertisement polling registers */
+               /* Unique 10G polling setup enforced by hardware design. Always same 10G PHYs. */
                if (phyinfo.poll_duplex || phyinfo.poll_adv_1000 || phyinfo.poll_lpa_1000) {
                        regmap_write(ctrl->map, RTMDIO_930X_SMI_10G_POLLING_REG0_CFG, phyinfo.poll_duplex);
                        regmap_write(ctrl->map, RTMDIO_930X_SMI_10G_POLLING_REG9_CFG, phyinfo.poll_adv_1000);
@@ -865,7 +865,7 @@ static void rtmdio_931x_setup_polling(struct rtmdio_ctrl *ctrl)
                regmap_assign_bits(ctrl->map, RTMDIO_931X_SMI_GLB_CTRL1,
                                   BIT(smi_bus * 2), phyinfo.force_res);
 
-               /* special polling registers */
+               /* Unique 10G polling setup enforced by hardware design. Always same 10G PHYs. */
                if (phyinfo.poll_duplex || phyinfo.poll_adv_1000 || phyinfo.poll_lpa_1000) {
                        regmap_write(ctrl->map, RTMDIO_931X_SMI_10GPHY_POLLING_SEL2, phyinfo.poll_duplex);
                        regmap_write(ctrl->map, RTMDIO_931X_SMI_10GPHY_POLLING_SEL3, phyinfo.poll_adv_1000);