]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test-json: avoid divide-by-zero coverity warning for index 9
authorLuca Boccassi <luca.boccassi@gmail.com>
Sat, 28 Mar 2026 22:32:06 +0000 (22:32 +0000)
committerLuca Boccassi <luca.boccassi@gmail.com>
Mon, 30 Mar 2026 12:11:25 +0000 (13:11 +0100)
Same fix as d0a066a1a4a391f629f7f52b5005103f8daf411f did for
index 10: add iszero_safe() check before dividing by the
json variant real value.

CID#1587762

Follow-up for d0a066a1a4a391f629f7f52b5005103f8daf411f

src/test/test-json.c

index d6308b23e7dbaad21039c125fad97e9c2b8330b4..016416dc4b7288624f00a22bbbd2f26b1cd75c5a 100644 (file)
@@ -665,6 +665,7 @@ static void test_float_match(sd_json_variant *v) {
                   sd_json_variant_integer(sd_json_variant_by_index(v, 8)) == -10);
         assert_se(sd_json_variant_is_real(sd_json_variant_by_index(v, 9)) &&
                   !sd_json_variant_is_integer(sd_json_variant_by_index(v, 9)));
+        assert_se(!iszero_safe(sd_json_variant_real(sd_json_variant_by_index(v, 9))));
         assert_se(fabs(1.0 - (DBL_MIN / 2 / sd_json_variant_real(sd_json_variant_by_index(v, 9)))) <= delta);
         assert_se(sd_json_variant_is_real(sd_json_variant_by_index(v, 10)) &&
                   !sd_json_variant_is_integer(sd_json_variant_by_index(v, 10)));