]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: dts: drop trailing semicolons after macro use 22614/head
authorJonas Jelonek <jelonek.jonas@gmail.com>
Thu, 26 Mar 2026 13:34:38 +0000 (13:34 +0000)
committerRobert Marko <robimarko@gmail.com>
Thu, 26 Mar 2026 13:48:24 +0000 (14:48 +0100)
Commit d52f7a4ca5 ("realtek: dts: new SWITCH_PORT_LED() macro") introduced
a new macro to simplify switch port definitions and introduces usage of
it for Zyxel XGS1X10-12 devices. However, this change added a DTS syntax
issue because:

> SWITCH_PORT_LED(...);

produces

> port@XX { ... };;

because the macro already includes a trailing semicolon. The DT compiler
doesn't like this so it fails with syntax error. Fix this by dropping the
trailing semicolons after macro usages.

Fixes: d52f7a4ca5 ("realtek: dts: new SWITCH_PORT_LED() macro")
Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/22614
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/dts/rtl9302_zyxel_xgs1x10-12-common.dtsi

index 6ddf6f6b933573409064d7136c0a3405fd94bcf7..44a7b248ee37677c6e4203c5cec590848a78952f 100644 (file)
                #address-cells = <1>;
                #size-cells = <0>;
                
-               SWITCH_PORT_LED(0, 1, 2, 0, usxgmii);
-               SWITCH_PORT_LED(1, 2, 2, 0, usxgmii);
-               SWITCH_PORT_LED(2, 3, 2, 0, usxgmii);
-               SWITCH_PORT_LED(3, 4, 2, 0, usxgmii);
-               SWITCH_PORT_LED(4, 5, 2, 0, usxgmii);
-               SWITCH_PORT_LED(5, 6, 2, 0, usxgmii);
-               SWITCH_PORT_LED(6, 7, 2, 0, usxgmii);
-               SWITCH_PORT_LED(7, 8, 2, 0, usxgmii);
+               SWITCH_PORT_LED(0, 1, 2, 0, usxgmii)
+               SWITCH_PORT_LED(1, 2, 2, 0, usxgmii)
+               SWITCH_PORT_LED(2, 3, 2, 0, usxgmii)
+               SWITCH_PORT_LED(3, 4, 2, 0, usxgmii)
+               SWITCH_PORT_LED(4, 5, 2, 0, usxgmii)
+               SWITCH_PORT_LED(5, 6, 2, 0, usxgmii)
+               SWITCH_PORT_LED(6, 7, 2, 0, usxgmii)
+               SWITCH_PORT_LED(7, 8, 2, 0, usxgmii)
 
                port@24 {
                        reg = <24>;