]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix wrong variable in named_server_sync() log message 12156/head
authorMichal Nowak <mnowak@isc.org>
Mon, 25 May 2026 06:52:31 +0000 (06:52 +0000)
committerMichal Nowak <mnowak@isc.org>
Mon, 1 Jun 2026 15:43:58 +0000 (17:43 +0200)
named_server_sync() logged isc_result_totext(result) but returns
tresult. The loop accumulates errors into tresult, so result only
holds the last iteration's value. If the last view succeeded but an
earlier one failed, the log would incorrectly say "success".

Assisted-by: Claude:claude-opus-4-7
(cherry picked from commit 1b984b1f116134d8a93c5327217487928f6d324f)

bin/named/server.c

index df4bb6ff4f3c4b670b0514317676b06f963cf562..51fb64da6529283e1bea42b2b01fc9e7e512f2c7 100644 (file)
@@ -12913,7 +12913,7 @@ named_server_sync(named_server_t *server, isc_lex_t *lex, isc_buffer_t **text) {
                              NAMED_LOGMODULE_SERVER, ISC_LOG_INFO,
                              "dumping all zones%s: %s",
                              cleanup ? ", removing journal files" : "",
-                             isc_result_totext(result));
+                             isc_result_totext(tresult));
                return tresult;
        }