]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc
authorJesse Zhang <jesse.zhang@amd.com>
Wed, 24 Apr 2024 09:10:46 +0000 (17:10 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Jul 2024 10:49:05 +0000 (12:49 +0200)
[ Upstream commit 88a9a467c548d0b3c7761b4fd54a68e70f9c0944 ]

Initialize the size before calling amdgpu_vce_cs_reloc, such as case 0x03000001.
V2: To really improve the handling we would actually
   need to have a separate value of 0xffffffff.(Christian)

Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
Suggested-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c

index 1904edf684071675cf5f10e6c354ba69d20f7afe..88a3aa36b41d77beadec2972e320fe27e5c70e05 100644 (file)
@@ -742,7 +742,8 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser *p,
        uint32_t created = 0;
        uint32_t allocated = 0;
        uint32_t tmp, handle = 0;
-       uint32_t *size = &tmp;
+       uint32_t dummy = 0xffffffff;
+       uint32_t *size = &dummy;
        unsigned int idx;
        int i, r = 0;