srptool: add missing fclose on error path

Spotted by gcc analyzer:
  srptool.c:113:32: warning: leak of FILE 'fp' [CWE-775] [-Wanalyzer-file-leak]
    113 |                         return -1;
        |                                ^
also:
  srptool.c:560:32: warning: leak of FILE 'fp' [CWE-775] [-Wanalyzer-file-leak]
    560 |                         return -1;
        |                                ^

Signed-off-by: Daiki Ueno <ueno@gnu.org>

diff --git a/src/srptool.c b/src/srptool.c
index 9326ac4dad34b00303ab1fcf1b870d0ab3f3d546..b4bc08b189f102f4c6ffaf1cddf94a291ba37e6a 100644 (file)
--- a/src/srptool.c
+++ b/src/srptool.c
@@ -110,6 +110,7 @@ static int generate_create_conf(const char *tpasswd_conf)
                        g = gnutls_srp_8192_group_generator;
                } else {
                        fprintf(stderr, "Unknown index: %d\n", index);
+                       fclose(fp);
                        return -1;
                }
 
@@ -585,6 +586,7 @@ crypt_int(const char *username, const char *passwd, int salt_size,
                        fprintf(stderr, "Cannot open '%s' for read\n",
                                tmpname);
                        (void)remove(tmpname);
+                       fclose(fp);
                        return -1;
                }