2232. [bug] dns_adb_findaddrinfo() could fail and return

                        ISC_R_SUCCESS. [RT #17137]

diff --git a/CHANGES b/CHANGES
index ba3dfa3a827be086eb2d3edd614545e5d607add1..c1dd2d879621a65cbcd3a69b848fbb1c086b7409 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+2232.  [bug]           dns_adb_findaddrinfo() could fail and return
+                       ISC_R_SUCCESS. [RT #17137]
+
 2231.  [bug]           Building dlzbdb (contrib/dlz/bin/dlzbdb) was broken.
                        [RT #17088]
 

diff --git a/lib/dns/adb.c b/lib/dns/adb.c
index 79b6a19ba27756352d202b512e32c67bd9d7ec9f..fb584cdc96f5e7aa47aa9201055cd5c97bbf2a5c 100644 (file)
--- a/lib/dns/adb.c
+++ b/lib/dns/adb.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: adb.c,v 1.231 2007/06/18 23:47:40 tbox Exp $ */
+/* $Id: adb.c,v 1.232 2007/09/11 02:18:38 marka Exp $ */
 
 /*! \file 
  *
@@ -3471,7 +3471,9 @@ dns_adb_findaddrinfo(dns_adb_t *adb, isc_sockaddr_t *sa,
 
        port = isc_sockaddr_getport(sa);
        addr = new_adbaddrinfo(adb, entry, port);
-       if (addr != NULL) {
+       if (addr == NULL) {
+               result = ISC_R_NOMEMORY;
+       } else {
                inc_entry_refcnt(adb, entry, ISC_FALSE);
                *addrp = addr;
        }