]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
posix-cpu-timers: Fix pid refcount leak in do_cpu_nanosleep() error path
authorWenTao Liang <vulab@iscas.ac.cn>
Thu, 11 Jun 2026 16:17:38 +0000 (00:17 +0800)
committerThomas Gleixner <tglx@kernel.org>
Sat, 13 Jun 2026 14:16:02 +0000 (16:16 +0200)
In do_cpu_nanosleep(), posix_cpu_timer_create() takes a pid reference
via get_pid() and stores it in timer.it.cpu.pid. If the subsequent
posix_cpu_timer_set() call fails, the function returns immediately
without calling posix_cpu_timer_del() to release the pid reference,
causing a leak.

Fix it by calling posix_cpu_timer_del() before the unlock-and-return
on the error path, consistent with the other exit paths in the same
function.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: WenTao Liang <vulab@iscas.ac.cn>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260611161738.97043-1-vulab@iscas.ac.cn
kernel/time/posix-cpu-timers.c

index 395e297093f89e1bf0d88b3b3fa1979f0d5f31ad..74775b94d11bd38a8f5daabdf8501df191045640 100644 (file)
@@ -1506,6 +1506,7 @@ static int do_cpu_nanosleep(const clockid_t which_clock, int flags,
                spin_lock_irq(&timer.it_lock);
                error = posix_cpu_timer_set(&timer, flags, &it, NULL);
                if (error) {
+                       posix_cpu_timer_del(&timer);
                        spin_unlock_irq(&timer.it_lock);
                        return error;
                }