Initialize buffers with { 0 } instead of memset

More details on threads:
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12178
https://gitlab.isc.org/isc-projects/bind9/-/merge_requests/291#note_12181

diff --git a/lib/dns/zoneverify.c b/lib/dns/zoneverify.c
index 5b1e185090ee1b8096f827587980a8f2d37edd56..22427764fb3ba95efdf8dc558b1c01e678941e7c 100644 (file)
--- a/lib/dns/zoneverify.c
+++ b/lib/dns/zoneverify.c
@@ -821,7 +821,7 @@ verifynsec3s(const vctx_t *vctx, const dns_name_t *name,
 static isc_result_t
 verifyset(vctx_t *vctx, dns_rdataset_t *rdataset, const dns_name_t *name,
          dns_dbnode_t *node, dst_key_t **dstkeys, size_t nkeys) {
-       unsigned char set_algorithms[256];
+       unsigned char set_algorithms[256] = { 0 };
        char namebuf[DNS_NAME_FORMATSIZE];
        char algbuf[DNS_SECALG_FORMATSIZE];
        char typebuf[DNS_RDATATYPE_FORMATSIZE];
@@ -862,7 +862,6 @@ verifyset(vctx_t *vctx, dns_rdataset_t *rdataset, const dns_name_t *name,
                goto done;
        }
 
-       memset(set_algorithms, 0, sizeof(set_algorithms));
        for (result = dns_rdataset_first(&sigrdataset); result == ISC_R_SUCCESS;
             result = dns_rdataset_next(&sigrdataset))
        {
@@ -926,7 +925,7 @@ verifynode(vctx_t *vctx, const dns_name_t *name, dns_dbnode_t *node,
           bool delegation, dst_key_t **dstkeys, size_t nkeys,
           dns_rdataset_t *nsecset, dns_rdataset_t *nsec3paramset,
           const dns_name_t *nextname, isc_result_t *vresult) {
-       unsigned char types[8192];
+       unsigned char types[8192] = { 0 };
        unsigned int maxtype = 0;
        dns_rdataset_t rdataset;
        dns_rdatasetiter_t *rdsiter = NULL;
@@ -934,7 +933,6 @@ verifynode(vctx_t *vctx, const dns_name_t *name, dns_dbnode_t *node,
 
        REQUIRE(vresult != NULL || (nsecset == NULL && nsec3paramset == NULL));
 
-       memset(types, 0, sizeof(types));
        result = dns_db_allrdatasets(vctx->db, node, vctx->ver, 0, &rdsiter);
        if (result != ISC_R_SUCCESS) {
                zoneverify_log_error(vctx, "dns_db_allrdatasets(): %s",