2126. [security] Serialise validation of type ANY responses. [RT #16555]

diff --git a/CHANGES b/CHANGES
index 9d2bab3eac8eea457f7f06b7afa18f28e4af97a4..875a296bf7f494d95022be403c2d47c1640291bc 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,4 @@
+2126.  [security]      Serialise validation of type ANY responses. [RT #16555]
 
        --- 9.2.1 released ---
 

diff --git a/lib/dns/include/dns/validator.h b/lib/dns/include/dns/validator.h
index a0d2bc4006b7be78c72819ab1d5655538972d496..3772ce19b28aa06af2eec87177e187ec9b46b572 100644 (file)
--- a/lib/dns/include/dns/validator.h
+++ b/lib/dns/include/dns/validator.h
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: validator.h,v 1.18 2001/01/09 21:53:39 bwelling Exp $ */
+/* $Id: validator.h,v 1.18.20.1 2007/02/09 00:05:54 marka Exp $ */
 
 #ifndef DNS_VALIDATOR_H
 #define DNS_VALIDATOR_H 1
@@ -111,6 +111,11 @@ struct dns_validator {
        ISC_LINK(dns_validator_t)       link;
 };
 
+/*%
+ * dns_validator_create() options.
+ */
+#define DNS_VALIDATOR_DEFER 2U
+
 ISC_LANG_BEGINDECLS
 
 isc_result_t
@@ -153,6 +158,15 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
  * part of a known insecure domain.
  */
 
+void
+dns_validator_send(dns_validator_t *validator);
+/*%<
+ * Send a deferred validation request
+ *
+ * Requires:
+ *     'validator' to points to a valid DNSSEC validator.
+ */
+
 void
 dns_validator_cancel(dns_validator_t *validator);
 /*

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index 4c1eeb0af05f5a2c25bba9ec24a79af4b4869ebf..9ed5f8017f802b00555639633e7a87413ab264fd 100644 (file)
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: resolver.c,v 1.218.2.10 2002/04/19 01:11:16 marka Exp $ */
+/* $Id: resolver.c,v 1.218.2.10.2.1 2007/02/09 00:05:54 marka Exp $ */
 
 #include <config.h>
 
@@ -697,6 +697,8 @@ fctx_query(fetchctx_t *fctx, dns_adbaddrinfo_t *addrinfo,
        if (result != ISC_R_SUCCESS)
                return (result);
 
+       INSIST(ISC_LIST_EMPTY(fctx->validators));
+
        dns_message_reset(fctx->rmessage, DNS_MESSAGE_INTENTPARSE);
 
        query = isc_mem_get(res->mctx, sizeof *query);
@@ -2443,12 +2445,21 @@ maybe_destroy(fetchctx_t *fctx) {
        unsigned int bucketnum;
        isc_boolean_t bucket_empty = ISC_FALSE;
        dns_resolver_t *res = fctx->res;
+       dns_validator_t *validator;
 
        REQUIRE(SHUTTINGDOWN(fctx));
 
-       if (fctx->pending != 0 || !ISC_LIST_EMPTY(fctx->validators))
+       if (fctx->pending != 0)
                return;
 
+       for (validator = ISC_LIST_HEAD(fctx->validators);
+            validator != NULL;
+            validator = ISC_LIST_HEAD(fctx->validators)) {
+               ISC_LIST_UNLINK(fctx->validators, validator, link);
+               dns_validator_cancel(validator);
+               dns_validator_destroy(&validator);
+       }
+
        bucketnum = fctx->bucketnum;
        LOCK(&res->buckets[bucketnum].lock);
        if (fctx->references == 0)
@@ -2631,7 +2642,9 @@ validated(isc_task_t *task, isc_event_t *event) {
                        goto noanswer_response;
        }
 
-       if (sentresponse) {
+       if (!ISC_LIST_EMPTY(fctx->validators))
+               dns_validator_send(ISC_LIST_HEAD(fctx->validators));
+       else if (sentresponse) {
                /*
                 * If we only deferred the destroy because we wanted to cache
                 * the data, destroy now.
@@ -2651,6 +2664,7 @@ validated(isc_task_t *task, isc_event_t *event) {
                 * more rdatasets that still need to
                 * be validated.
                 */
+               dns_validator_send(ISC_LIST_HEAD(fctx->validators));
                goto cleanup_event;
        }
 
@@ -2699,6 +2713,7 @@ cache_name(fetchctx_t *fctx, dns_name_t *name, isc_stdtime_t now) {
        unsigned int options;
        isc_task_t *task;
        dns_validator_t *validator;
+       unsigned int valoptions = 0;
 
        /*
         * The appropriate bucket lock must be held.
@@ -2886,15 +2901,18 @@ cache_name(fetchctx_t *fctx, dns_name_t *name, isc_stdtime_t now) {
                                                rdataset,
                                                sigrdataset,
                                                fctx->rmessage,
-                                               0,
+                                               valoptions,
                                                task,
                                                validated,
                                                fctx,
                                                &validator);
-                                       if (result == ISC_R_SUCCESS)
+                                       if (result == ISC_R_SUCCESS) {
                                                ISC_LIST_APPEND(
                                                        fctx->validators,
                                                        validator, link);
+                                               valoptions |=
+                                                        DNS_VALIDATOR_DEFER;
+                                       }
                                }
                        }
                } else if (!EXTERNAL(rdataset)) {
@@ -2967,7 +2985,7 @@ cache_name(fetchctx_t *fctx, dns_name_t *name, isc_stdtime_t now) {
                                              valrdataset,
                                              valsigrdataset,
                                              fctx->rmessage,
-                                             0,
+                                             valoptions,
                                              task,
                                              validated,
                                              fctx,

diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index f6ad061ee18d7ad544d303e5f3ddb7b98f0ef7b2..d5176de98c15dc8f465476f651431b6372531ee4 100644 (file)
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: validator.c,v 1.91.2.1 2001/09/19 21:51:40 bwelling Exp $ */
+/* $Id: validator.c,v 1.91.2.1.4.1 2007/02/09 00:05:54 marka Exp $ */
 
 #include <config.h>
 
@@ -1514,7 +1514,8 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
        ISC_LINK_INIT(val, link);
        val->magic = VALIDATOR_MAGIC;
 
-       isc_task_send(task, (isc_event_t **)&event);
+       if ((options & DNS_VALIDATOR_DEFER) == 0)
+               isc_task_send(task, (isc_event_t **)&event);
 
        *validatorp = val;
 
@@ -1531,6 +1532,21 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
        return (result);
 }
 
+void
+dns_validator_send(dns_validator_t *validator) {
+       isc_event_t *event;
+       REQUIRE(VALID_VALIDATOR(validator));
+
+       LOCK(&validator->lock);
+
+       INSIST((validator->options & DNS_VALIDATOR_DEFER) != 0);
+       event = (isc_event_t *)validator->event;
+       validator->options &= ~DNS_VALIDATOR_DEFER;
+       UNLOCK(&validator->lock);
+
+       isc_task_send(validator->task, &event);
+}
+
 void
 dns_validator_cancel(dns_validator_t *validator) {
        REQUIRE(VALID_VALIDATOR(validator));
@@ -1550,6 +1566,13 @@ dns_validator_cancel(dns_validator_t *validator) {
 
                if (validator->authvalidator != NULL)
                        dns_validator_cancel(validator->authvalidator);
+
+               if ((validator->options & DNS_VALIDATOR_DEFER) != 0) {
+                       isc_task_t *task = validator->event->ev_sender;
+                       validator->options &= ~DNS_VALIDATOR_DEFER;
+                       isc_event_free((isc_event_t **)&validator->event);
+                       isc_task_detach(&task);
+               }
        }
        UNLOCK(&validator->lock);
 }