]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: nomadik: Add missing IS_ERR() check
authorEthan Tidmore <ethantidmore06@gmail.com>
Sat, 14 Feb 2026 04:45:31 +0000 (22:45 -0600)
committerSasha Levin <sashal@kernel.org>
Wed, 4 Mar 2026 12:21:32 +0000 (07:21 -0500)
[ Upstream commit 58433885ee99e8c96757e82ccf6d50646c4dfe09 ]

The function gpio_device_get_desc() can return an error pointer and is
not checked for one. Add check for error pointer.

Fixes: ddeb66d2cb10f ("gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks")
Cc: stable@vger.kernel.org
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Link: https://patch.msgid.link/20260214044531.43539-1-ethantidmore06@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-nomadik.c

index 97c5cd33279d561c56ea508e3970566da02a5d6d..e22b713166d71d9160d8bddb932f26f4a158e672 100644 (file)
@@ -430,6 +430,9 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev,
 #ifdef CONFIG_PINCTRL_NOMADIK
        if (mode == NMK_GPIO_ALT_C && pctldev) {
                desc = gpio_device_get_desc(chip->gpiodev, offset);
+               if (IS_ERR(desc))
+                       return;
+
                mode = nmk_prcm_gpiocr_get_mode(pctldev, desc_to_gpio(desc));
        }
 #endif