]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: Intel: catpt: Remove unused WAVES controls
authorCezary Rojewski <cezary.rojewski@intel.com>
Wed, 3 Jun 2026 08:58:25 +0000 (10:58 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 4 Jun 2026 16:00:25 +0000 (17:00 +0100)
Support for the WAVES module was never officially published.  The
kcontrols present in the existing code were added to retain 1:1 UAPI
with catpt-driver's predecessor, the haswell-driver despite the lack of
users for the functionality.  Several years have passed since the
successful transition to the catpt-driver and removal of its predecessor
and there is no reason to keep the unused code.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20260603085827.1964796-6-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/catpt/pcm.c

index ba0c75f4b4e7d1563c222cab19be77ad2c98acc2..faa9c483c98e17aa2268a7b0fbb8b391822bddca 100644 (file)
@@ -968,32 +968,6 @@ static int catpt_loopback_mute_put(struct snd_kcontrol *kctl, struct snd_ctl_ele
        return 1;
 }
 
-static int catpt_waves_switch_get(struct snd_kcontrol *kcontrol,
-                                 struct snd_ctl_elem_value *ucontrol)
-{
-       return 0;
-}
-
-static int catpt_waves_switch_put(struct snd_kcontrol *kcontrol,
-                                 struct snd_ctl_elem_value *ucontrol)
-{
-       return 0;
-}
-
-static int catpt_waves_param_get(struct snd_kcontrol *kcontrol,
-                                unsigned int __user *bytes,
-                                unsigned int size)
-{
-       return 0;
-}
-
-static int catpt_waves_param_put(struct snd_kcontrol *kcontrol,
-                                const unsigned int __user *bytes,
-                                unsigned int size)
-{
-       return 0;
-}
-
 static const SNDRV_CTL_TLVD_DECLARE_DB_SCALE(catpt_volume_tlv, -9000, 300, 1);
 
 #define CATPT_VOLUME_CTL(kname, pname) {               \
@@ -1018,12 +992,6 @@ CATPT_VOLUME_CTL("Media1 Playback Volume", OFFLOAD2),
 CATPT_VOLUME_CTL("Mic Capture Volume", CAPTURE1),
 SOC_SINGLE_BOOL_EXT("Loopback Mute", (unsigned long)&(bool[1]) {0},
                    catpt_loopback_mute_get, catpt_loopback_mute_put),
-/* Enable or disable WAVES module */
-SOC_SINGLE_BOOL_EXT("Waves Switch", 0,
-                   catpt_waves_switch_get, catpt_waves_switch_put),
-/* WAVES module parameter control */
-SND_SOC_BYTES_TLV("Waves Set Param", 128,
-                 catpt_waves_param_get, catpt_waves_param_put),
 };
 
 static const struct snd_soc_dapm_widget component_widgets[] = {